[ivtv-devel] [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

Lawrence Rust lawrence at softsystem.co.uk
Mon Jan 10 13:56:27 CET 2011


On Mon, 2011-01-10 at 07:39 -0500, Andy Walls wrote:
[snip]
> I do see one problem with your patch at the moment:
> 
> diff --git a/include/media/wm8775.c b/include/media/wm8775.c
> ...
> +       sd->grp_id = WM8775_GID; /* subdev group id */
> ...
> diff --git a/include/media/wm8775.h b/include/media/wm8775.h
> ...
> +/* subdev group ID */
> +#define WM8775_GID (1 << 0)
> +
> ...
> 
> 
> The wm8775 module probably should not define WM8775_GID and definitely
> should not set sd->grp_id.  The sd->grp_id is for the bridge driver's
> use for that v4l2_subdev instance.  Some bridge drivers may expect it to
> be 0 unless they set it themselves.  The group ID values should be
> defined in the bridge driver, and the sd->grp_id field should be set by
> the bridge driver.
> 
> You would want to do that in cx88.  See cx23885, ivtv, and cx18 as
> examples of bridge drivers that use the group id field.

You know what, life's too short.  I've spent far too long on this at the
expense of far more interesting projects.  Every time I put some effort
in someone says just one more thing...  I get the message.  I'll just
keep the patch for my personal use.  For those that are interested I'll
maintain a copy here:
http://www.softsystem.co.uk/download/patches/nova-2.6.37.patch

-- Lawrence





More information about the ivtv-devel mailing list