[ivtv-devel] 0.3.9: saa7127 compile error with gcc 2.95 (woody)

[Martin Dauskardt]

> Date: Wed, 28 Sep 2005 16:13:35 +0200 (CEST)
> From: Leonard Orb <leo509 at spishak.de>
> Subject: Re: [ivtv-devel] 0.3.9: saa7127 compile error with gcc 2.95
> 	(woody)
> To: ivtv-devel at ivtvdriver.org
> Message-ID: <ID4.62-05091c1000310.42e0 at crelm.de>
> Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
> 
> On Wed, 28 Sep 2005, Martin Dauskardt wrote:
> 
> > I tried the latest version (saa7127.c is from 28.09.05 00:00)
> >
> > (0.3.7k compiled without problems)
> >
> > CC [M]  /usr/local/src/ivtv/ivtv/trunk/driver/saa7127.o
> > /usr/local/src/ivtv/ivtv/trunk/driver/saa7127.c: In function
> > `saa7127_writereg':
> > /usr/local/src/ivtv/ivtv/trunk/driver/saa7127.c:265: parse 
> error before `)'
> > /usr/local/src/ivtv/ivtv/trunk/driver/saa7127.c: In function
> > `saa7127_set_wss_mode':
> > /usr/local/src/ivtv/ivtv/trunk/driver/saa7127.c:370: parse 
> error before `)'
> > ...
> 
> The macros "SAA7127_ERR" and "SAA7127_DEBUG" are defined for a variable 
> parameter count.
> Gcc 2.95 expects at least one of the optional parameters to be there 
> (i.e. two parameters for both macros), so best practice would be to 
> add a ", 0" to each "SAA7127_ERR" and "SAA7127_DEBUG" that has only one 
> parameter. Try 'SAA7127_ERR("I2C Write Problem\n", 0);'
> instead of 'SAA7127_ERR("I2C Write Problem\n");'
> 
> Gcc 2.95 will then yield warnings instead of errors.

Thanks a lot Leo, this worked !!